Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipelines/codepipeline] improve existing Action interface #9624

Closed
rix0rrr opened this issue Aug 12, 2020 · 7 comments
Closed

[pipelines/codepipeline] improve existing Action interface #9624

rix0rrr opened this issue Aug 12, 2020 · 7 comments
Assignees
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline @aws-cdk/pipelines CDK Pipelines library effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 12, 2020

Need to address the following:

  • More flexible ordering among Actions (autoderive ordering via artifacts and other relative "before/after" constraints)
  • Change ordering among Stages (necessary to insert stages later)
  • Make it easier to create new Actions (current interface is rather cumbersome, around actionProperties()/bind()/bound()).

More abstract things to think about:

  • Compound actions?
  • Should actions and stages not have been constructs?
  • It should be easy to add a CodeBuild project to a pipeline "in one go", while allowing max. customization

This is a 🚀 Feature Request

@rix0rrr rix0rrr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 12, 2020
@rix0rrr rix0rrr added this to the [CDK Pipelines] Soon milestone Aug 12, 2020
@rix0rrr rix0rrr added @aws-cdk/aws-codepipeline Related to AWS CodePipeline @aws-cdk/pipelines CDK Pipelines library p1 labels Aug 12, 2020
@rix0rrr rix0rrr self-assigned this Aug 12, 2020
@rix0rrr rix0rrr added the effort/large Large work item – several weeks of effort label Aug 17, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Aug 18, 2020
@pcolazurdo
Copy link

pcolazurdo commented Dec 26, 2020

Facing an issue related with this when trying to add permissions to the Action Role.

I'd prefer to have an interface like 'addToRolePolicy' in the CodeBuild module than having to define the role from scratch and assigning it to the Action.

As the Role is not exposed directly I'm finding very hard to use the existing interfaces to modify this.

@skinny85
Copy link
Contributor

Why do you need to add permissions to that Role @pcolazurdo ?

@pcolazurdo
Copy link

In my case, I need to use a Full Clone to use AWS Copilot CLI - The permission setup for this are documented here and here

@skinny85
Copy link
Contributor

I feel like that's more of a matter of the CodeCommitSourceAction not having support for that option.

But thanks!

@pcolazurdo
Copy link

I've also created a FR for the CodeCommitSourceAction but that will only solve the CodeCommit permissions, it should not change the CodeBuild construct.

Additionally, in my use case, I also had to add a policy to let the CodeBuild Role to assume a Role created by AWS Copilot to let CodeBuild call a stack change (this is due to how Copilot works but I can see this happening with other tools/frameworks)

@rix0rrr rix0rrr removed this from the [GA] CDK Pipelines milestone Jan 7, 2021
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jan 7, 2021

This change is unlikely to be necessary anymore as we've changed strategies for #10872

@rix0rrr rix0rrr closed this as completed Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline @aws-cdk/pipelines CDK Pipelines library effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

4 participants