Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): allow setting concurrent build limit #14099

Closed
wants to merge 1 commit into from

Conversation

gmokki
Copy link
Contributor

@gmokki gmokki commented Apr 10, 2021

Add support for specifying the concurrent build limit for codebuild project.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 10, 2021

@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Apr 10, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 867dac3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 changed the title feat(aws-codebuild): allow setting concurrent build limit feat(codebuild): allow setting concurrent build limit Apr 12, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @gmokki!

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@gmokki
Copy link
Contributor Author

gmokki commented Apr 14, 2021

I spent a long time looking for that checkbox. But it seems I should have forked this repository under my personal account and not under organization account: isaacs/github#1681
Which of these should I do now?

  1. click the "update branch" button manually
  2. force push a rebase in my own PR branch manually
  3. close this PR and create a new PR forked into my personal account so that I can select the checkbox
  4. something else?

@skinny85
Copy link
Contributor

  1. close this PR and create a new PR forked into my personal account so that I can select the checkbox

That's what I would recommend 🙂.

@skinny85
Copy link
Contributor

Done in #14185.

@skinny85 skinny85 closed this Apr 15, 2021
mergify bot pushed a commit that referenced this pull request Apr 15, 2021
Add support for specifying the concurrent build limit for codebuild project.

This is identical to #14099 - which could not be merged because it was based on fork in corporate github organization.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Add support for specifying the concurrent build limit for codebuild project.

This is identical to aws#14099 - which could not be merged because it was based on fork in corporate github organization.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants