fix(stepfunctions): make grants work when state machines are imported from other accounts or regions #18737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-stepfunctions
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Hi @flavioleggio, I think the bug is a lot simpler than this change. See #19026 for my idea. |
|
Hello @kaizen3031593, if your PR solves the issue, I think we can close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the process of composing executions' arn when
grantRead()andgrantExecution()methods are called on aIStateMachineconstruct.This bug assigned a wrong arn to resources referenced in the IAM policy when the
IStateMachinewas imported from a different account or region than the current stack.The private
executionArn()method now uses all arn components of theIStateMachineto build the arn string, rather than leavingaccountandregioncomponents to the default values.Fixes #17982
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license