feat(aws-ecs): Adds an addSecret() method for a ContainerDefinition

[danwiltshire]

I'm using Aspects to configure already-instantiated resources in CDK. This PR will enable adding a Secret to a ContainerDefinition, similar to addEnvironment().

Had to remove the readonly modifier to allow the addSecret() method to set or push secrets. Let me know if there's a better way of handling this.

Added an integration test, worked as expected in my environment.

closes #18959

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[robertd]

@madeline-k Can you please review this and merge in when time permits? We need this in our current ECS projects & workflows. TIA.

[madeline-k]

Thank you for implementing this feature, @danwiltshire! Nice work. I just have one comment.

Pull request has been modified.

[danwiltshire]

@madeline-k Hello, I updated the PR as requested but these tests are now failing. Do you know how to resolve this?

Thanks

API elements with incompatible changes:
err  - PROP @aws-cdk/aws-ecs.ContainerDefinition.referencesSecretJsonField: changed from property to method [changed-kind:@aws-cdk/aws-ecs.ContainerDefinition.referencesSecretJsonField]
err  - PROP @aws-cdk/aws-ecs.FirelensLogRouter.referencesSecretJsonField: changed from property to method [changed-kind:@aws-cdk/aws-ecs.FirelensLogRouter.referencesSecretJsonField]

[aws-cdk-automation]

This PR has been in BUILD FAILING for 21 days, and looks abandoned. It will be closed in 10 days if no further commits are pushed to it.

[anelson]

@madeline-k it looks like this PR has gone stale. We really need this ability in our project. Is there anything I could do to get this moving forward?

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 199bd32
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[jishi]

Maybe use getter syntax to allow it to be accessed as a property is what needs to be changed:

public get referencesSecretJsonField(): boolean {

That would allow it to be accessed as obj.referencesSecretJsonField thus not breaking API spec.

[jishi]

Additionally, it could probably also just check length of secrets array thus not requiring the private backing field.

[github-actions]

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[github-actions]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.