Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): CLI hangs for 10 minutes on expired credentials #21052

Merged
merged 7 commits into from
Aug 19, 2022

Commits on Jul 8, 2022

  1. fix(cli): CLI hangs for 10 minutes on expired credentials

    When using environment variable credentials (`AWS_ACCESS_KEY_ID` etc)
    that were expired, the CLI would proceed to retry calls involving those
    credentials because the `ExpiredToken` error is marked as `retryable:
    true`.
    
    Because we have extremely aggressive timeouts for most of our SDK calls
    (since the CloudFormation throttling limits are low and we generate a
    lot of contention on them), calls can take up to 10 minutes to run out
    of retries.
    
    Try and detect `ExpiredToken` situations sooner and error out harder
    without trying to recover from them.
    
    This PR only handles the situation where there is a Roles to assume --
    this works because calls to STS have a much lower retry count, and so
    it only takes a couple of seconds to run out of retries and surface
    the `ExpiredToken` to the CLI, which we can then use to abort early.
    rix0rrr committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    1241c15 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Configuration menu
    Copy the full SHA
    49e8d1b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Configuration menu
    Copy the full SHA
    c63aa96 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e06432 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Configuration menu
    Copy the full SHA
    a67750f View commit details
    Browse the repository at this point in the history
  2. Fix cyclic dep

    rix0rrr committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    402139c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    30553b9 View commit details
    Browse the repository at this point in the history