Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integ-runner): use newStyleSynthesis by default #21856

Merged
merged 11 commits into from
Aug 31, 2022
Merged

chore(integ-runner): use newStyleSynthesis by default #21856

merged 11 commits into from
Aug 31, 2022

Conversation

corymhall
Copy link
Contributor

This PR updates the integ-runner to not set @aws-cdk/core:newStyleStackSynthesis: false by default.
Previously this was done to cut down on the merge conflicts when the forward-merge was done
between v1 and v2, but since we are now only committing to v2 it makes sense to test with
newStyleStackSynthesis enabled.

This change required re-running all integration tests since using this flag changes the template. I've separated out some of the important changes into their own commits to make it easier to review.

  • chore(integ-runner): use newStyleSynthesis by default - this contains the actual change to the integ-runner
  • integ test shapshot updates - this contains the snapshot updates for most of the tests
  • The commits that mention a specific module contain fixes for broken integration tests

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 31, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team August 31, 2022 17:06
@github-actions github-actions bot added the p2 label Aug 31, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 31, 2022
Copy link
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realistically, my eyes might have glossed over a few changes.
Having gone through them commit by commit, I think it's as close to an in-depth review as humanly possible.

aws-amplify-alpha so removing the piece that causes the failure (diff in
nested stack asset hash).
@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0150e65
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f593a8e into aws:main Aug 31, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@corymhall corymhall deleted the corymhall/integ/newStyleSynthesis branch August 31, 2022 21:27
@corymhall corymhall mentioned this pull request Sep 1, 2022
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants