Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions): cfnSpec breaks definitionSubstitutions prop #21887

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

peterwoodworth
Copy link
Contributor

Patches cfnspec to allow CfnStateMachine.DefinitionSubstitutions to synthesize again

fixes: #21653


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 1, 2022

@github-actions github-actions bot added the p2 label Sep 1, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team September 1, 2022 23:43
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 1, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6015b0a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/exempt-test The PR linter will not require test changes label Sep 2, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3adf841 into main Sep 2, 2022
@mergify mergify bot deleted the peterwoodworth/statemachineCfnPatch branch September 2, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-lib/aws_stepfunctions: definitionSubstitutions: element should be an 'object'
3 participants