Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elbv2): connections not created for chained listener actions #21939

Merged
merged 3 commits into from
Sep 8, 2022
Merged

fix(elbv2): connections not created for chained listener actions #21939

merged 3 commits into from
Sep 8, 2022

Commits on Sep 7, 2022

  1. fix(elbv2): connections not created for chained listener actions

    When you add an action to a listener the `bind` method is called, and
    one of the things that is typically done is to configure security group
    ingress. When you chain actions together, i.e.
    
    ```ts
    listener.addAction('first-action', {
      action: ListenerAction.authenticateOidc({
        next: ListenerAction.forward([secondAction]),
        ...,
      }),
    });
    ```
    
    Bind is never called for the second action (i.e. `next`) which means the
    security group ingress rules are not created.
    
    This PR updates the `ListenerAction.bind` method to call `bind` for any
    `next` action that is configured.
    
    fixes #12994
    corymhall committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ed8a5be View commit details
    Browse the repository at this point in the history
  2. fixing test

    corymhall committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    112a5f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    4a794df View commit details
    Browse the repository at this point in the history