-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synthetics): latest canary runtimes for NodeJS, Python #29132
Conversation
Two queries for this one:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
FYI. This is pretty critical since AWS just sent out a note about a planned lifecycle event by March 19, 2024:
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Yep, that's why I'm raising the PR - we got health alerts in our accounts for the deprecation 👍 |
I believe that the integration test snapshot should now be in a good state but I had a certain amount of fun trying to get it there. Someone more familiar should definitely check this over 😅 |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me thanks for this update @wilhen01
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #29135 ### Reason for this change Surface latest runtime versions in CDK. Older runtimes are being deprecated March 19, 2024 > To ensure uninterrupted canary runs and continued monitoring, AWS recommends customers to update their canaries to the latest Synthetics Runtimes versions: syn-nodejs-puppeteer-6.2 or higher for NodeJS-18, syn-nodejs-puppeteer-5.2 or higher for NodeJS-16, and syn-python-selenium-2.1 or higher for Python [2]. Canaries updated with latest Synthetics runtimes will continue running without interruption and receive future Lambda security updates. ### Description of changes - feat(synthetics): add 5.2, 6.1, 6.2 nodejs runtimes, deprecate 3.x runtimes - feat(synthetics): add syn-python-selenium-2.1 runtime - test(synthetics): update integration tests to cover latest runtimes ### Description of how you validated changes Attempted to run integration tests, but I don't have appropriate account setup ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@msambol those runtimes weren't deprecated when this PR was merged on Feb 22nd. Someone should raise a PR to deprecate them now that we're past the deprecation date - go for it if you have time 😄 |
Oops! I saw your message in slack and thought it was from today. I'll do another PR. |
Closes #29135
Reason for this change
Surface latest runtime versions in CDK. Older runtimes are being deprecated March 19, 2024
Description of changes
Description of how you validated changes
Attempted to run integration tests, but I don't have appropriate account setup
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license