-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(codebuild): aarch64 standard 2.0 and 3.0 build images are not deprecated #29580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: this change doesn't change any feature or functionality — thus, no test should and does not change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Left a comment for updating v2 documentation as well.
I think you can mark the PR as a chore
(CI won't require tests).
Also, can you please update the title to not be truncated?
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
I removed the |
Hey, guess I didn't open a PR for this (I was sure I did), but I already have a runner ready to update all of the CodeBuild images ( Regardless, you can confirm that these images are still available by using the $ aws codebuild list-curated-environment-images | jq '.platforms[] | select(.platform == "AMAZON_LINUX_2") | .languages[] | select(.language == "STANDARD") | .images[] | select(.name == "aws/codebuild/amazonlinux2-aarch64-standard:3.0")'
{
"name": "aws/codebuild/amazonlinux2-aarch64-standard:3.0",
"description": "AWS CodeBuild - Docker image based on Amazon Linux 2023 (aarch64) with multiple language support",
"versions": [
"aws/codebuild/amazonlinux2-aarch64-standard:3.0-23.04.25",
"aws/codebuild/amazonlinux2-aarch64-standard:3.0-24.01.29",
"aws/codebuild/amazonlinux2-aarch64-standard:3.0-24.03.06",
"aws/codebuild/amazonlinux2-aarch64-standard:3.0-24.03.21"
]
} $ aws codebuild list-curated-environment-images | jq '.platforms[] | select(.platform == "AMAZON_LINUX_2") | .languages[] | select(.language == "STANDARD") | .images[] | select(.name == "aws/codebuild/amazonlinux2-aarch64-standard:2.0")'
{
"name": "aws/codebuild/amazonlinux2-aarch64-standard:2.0",
"description": "AWS CodeBuild - Docker image based on Amazon Linux 2 (aarch64) with multiple language support",
"versions": [
"aws/codebuild/amazonlinux2-aarch64-standard:2.0-20.06.15",
"aws/codebuild/amazonlinux2-aarch64-standard:2.0-20.08.13",
"aws/codebuild/amazonlinux2-aarch64-standard:2.0-21.01.12",
"aws/codebuild/amazonlinux2-aarch64-standard:2.0-21.03.02",
"aws/codebuild/amazonlinux2-aarch64-standard:2.0-21.08.20",
"aws/codebuild/amazonlinux2-aarch64-standard:2.0-21.10.15",
"aws/codebuild/amazonlinux2-aarch64-standard:2.0-24.01.29",
"aws/codebuild/amazonlinux2-aarch64-standard:2.0-24.03.06",
"aws/codebuild/amazonlinux2-aarch64-standard:2.0-24.03.21"
]
} |
I opened another PR to fix this issue, among other things: #29616 |
@Mergifyio update |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
☑️ Nothing to do
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Closes #.
Reason for this change
AWS CodeBuild Docker images
AMAZON_LINUX_2_ARM_3
akaAMAZON_LINUX_2_STANDARD_3_0
akaaws/codebuild/amazonlinux2-aarch64-standard:3.0
andAMAZON_LINUX_2_ARM_2
akaAMAZON_LINUX_2_STANDARD_2_0
akaaws/codebuild/amazonlinux2-aarch64-standard:2.0
are not deprecated but the currently actively maintained ones according to https://github.com/aws/aws-codebuild-docker-images and https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.htmlDescription of changes
I removed the JSDoc Deprecated flag for the currently active images and added their image names as a comment so that one can find the images also using those references.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license