From bc70984d066e0144a74af38b585207f7d235af87 Mon Sep 17 00:00:00 2001 From: Andrei Alecu Date: Thu, 25 Apr 2024 15:16:52 +0300 Subject: [PATCH] fix(crossRegionReference): error message missing stack information fixed #29699 --- .../lib/core/cross-region-ssm-writer-handler/index.ts | 4 ++-- .../test/core/cross-region-ssm-writer-handler.test.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/@aws-cdk/custom-resource-handlers/lib/core/cross-region-ssm-writer-handler/index.ts b/packages/@aws-cdk/custom-resource-handlers/lib/core/cross-region-ssm-writer-handler/index.ts index 33a6612439e9f..8a944d75854b6 100644 --- a/packages/@aws-cdk/custom-resource-handlers/lib/core/cross-region-ssm-writer-handler/index.ts +++ b/packages/@aws-cdk/custom-resource-handlers/lib/core/cross-region-ssm-writer-handler/index.ts @@ -102,8 +102,8 @@ async function throwIfAnyInUse(ssm: SSM, parameters: CrossRegionExports): Promis })); if (tagResults.size > 0) { - const message: string = Object.entries(tagResults) - .map((result: [string, string[]]) => `${result[0]} is in use by stack(s) ${result[1].join(' ')}`) + const message: string = Array.from(tagResults.entries()) + .map((result) => `${result[0]} is in use by stack(s) ${Array.from(result[1]).join(' ')}`) .join('\n'); throw new Error(`Exports cannot be updated: \n${message}`); } diff --git a/packages/@aws-cdk/custom-resource-handlers/test/core/cross-region-ssm-writer-handler.test.ts b/packages/@aws-cdk/custom-resource-handlers/test/core/cross-region-ssm-writer-handler.test.ts index a09a449e99d2e..28107c6b145f8 100644 --- a/packages/@aws-cdk/custom-resource-handlers/test/core/cross-region-ssm-writer-handler.test.ts +++ b/packages/@aws-cdk/custom-resource-handlers/test/core/cross-region-ssm-writer-handler.test.ts @@ -1,7 +1,7 @@ /* eslint-disable import/no-extraneous-dependencies */ import { InvalidResourceId } from '@aws-sdk/client-ssm'; -import { SSM_EXPORT_PATH_PREFIX } from '../../lib/core/types'; import { handler } from '../../lib/core/cross-region-ssm-writer-handler/index'; +import { SSM_EXPORT_PATH_PREFIX } from '../../lib/core/types'; let mockPutParameter: jest.Mock = jest.fn() ; let mocklistTagsForResource: jest.Mock = jest.fn(); @@ -96,7 +96,7 @@ describe('cross-region-ssm-writer entrypoint', () => { }); // THEN - await expect(handler(event)).rejects.toThrow(/Exports cannot be updated/); + await expect(handler(event)).rejects.toThrow('Exports cannot be updated: \n/cdk/exports/MyStack/MyExport is in use by stack(s) MyStack'); }); test('Create event does not throw for new parameters', async () => {