Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(elasticloadbalancingv2): fix NLB attributes integ test #29971

Closed
wants to merge 2 commits into from

Conversation

badmintoncryer
Copy link
Contributor

Issue # (if applicable)

Closes #29970.

Reason for this change

Existing integ test (integ.nlb-attributes.ts) fails to deploy because denyAllIgwTraffic is not configurable for IPV4 load balancer.

new elbv2.NetworkLoadBalancer(stack, 'NLB', {
  vpc,
  denyAllIgwTraffic: true, // This parameter is not configurable for IPV4 loadbalancer
});

Description of changes

  • Remove the denyAllIgwTraffic setting from integ.nlb-attribute.ts
  • Instead, set denyAllIgwTraffic in integ.nlb.dualstack.internal.ts.

Description of how you validated changes

I've updated integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Apr 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 26, 2024 07:42
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4616172
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

This was referenced Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticloadbalancingv2: fail to deploy integ test for NLB attributes
2 participants