From e06a2cb3ccc9d5832f8bb2fd8310f5755e1e6107 Mon Sep 17 00:00:00 2001 From: Pahud Hsieh Date: Wed, 17 Jul 2024 18:00:52 -0400 Subject: [PATCH 1/3] chore(doc): Update INTEGRATION_TESTS.md callout the env.account should not be defined --- INTEGRATION_TESTS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/INTEGRATION_TESTS.md b/INTEGRATION_TESTS.md index 2073ec66a9a9e..ab196943c76db 100644 --- a/INTEGRATION_TESTS.md +++ b/INTEGRATION_TESTS.md @@ -119,6 +119,9 @@ This will: Now when you run `npm test` it will synth the integ app and compare the result with the snapshot. If the snapshot has changed the same process must be followed to update the snapshot. +*Note - When running integration tests, refrain from defining the `env.account` property for stacks. This ensures that the synthesized +CloudFormation template from the snapshots does not contain your current AWS account information, promoting better security and portability. + ### New L2 Constructs When creating a new L2 construct (or new construct library) it is important to ensure you have a good From fec6ce0d174a3e2ac887cbb124630483f833c3ee Mon Sep 17 00:00:00 2001 From: Pahud Hsieh Date: Wed, 17 Jul 2024 18:12:23 -0400 Subject: [PATCH 2/3] Update INTEGRATION_TESTS.md --- INTEGRATION_TESTS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INTEGRATION_TESTS.md b/INTEGRATION_TESTS.md index ab196943c76db..2a418be0bd108 100644 --- a/INTEGRATION_TESTS.md +++ b/INTEGRATION_TESTS.md @@ -120,7 +120,7 @@ Now when you run `npm test` it will synth the integ app and compare the result w If the snapshot has changed the same process must be followed to update the snapshot. *Note - When running integration tests, refrain from defining the `env.account` property for stacks. This ensures that the synthesized -CloudFormation template from the snapshots does not contain your current AWS account information, promoting better security and portability. +CloudFormation template from the snapshots does not contain your current AWS account information, promoting better security and portability.* ### New L2 Constructs From 318e86b89d81fab37b44169c823919f84785b564 Mon Sep 17 00:00:00 2001 From: Pahud Hsieh Date: Wed, 17 Jul 2024 18:14:58 -0400 Subject: [PATCH 3/3] Update INTEGRATION_TESTS.md --- INTEGRATION_TESTS.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/INTEGRATION_TESTS.md b/INTEGRATION_TESTS.md index 2a418be0bd108..4511d587fb52f 100644 --- a/INTEGRATION_TESTS.md +++ b/INTEGRATION_TESTS.md @@ -119,8 +119,7 @@ This will: Now when you run `npm test` it will synth the integ app and compare the result with the snapshot. If the snapshot has changed the same process must be followed to update the snapshot. -*Note - When running integration tests, refrain from defining the `env.account` property for stacks. This ensures that the synthesized -CloudFormation template from the snapshots does not contain your current AWS account information, promoting better security and portability.* +*Note - When running integration tests, `env.account` is generally not required unless some special cases like cross-account tests.* ### New L2 Constructs