Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: un-bump codecov/codecov-action from 5 to 4 #32314

Merged

Conversation

Leo10Gama
Copy link
Member

Reverts #32173

Codecov v5 is throwing errors with some PRs (e.g. failing workflow) and reportedly has many issues. The quick-fix until they resolve their issues is to downgrade the version of codecov we are using back to v4.

@aws-cdk-automation aws-cdk-automation requested a review from a team November 27, 2024 18:03
@github-actions github-actions bot added the p2 label Nov 27, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 27, 2024
@mrgrain mrgrain changed the title revert: un-bump codecov/codecov-action from 5 to 4 chore: un-bump codecov/codecov-action from 5 to 4 Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.19%. Comparing base (069b72c) to head (d97f038).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32314   +/-   ##
=======================================
  Coverage   78.19%   78.19%           
=======================================
  Files         105      105           
  Lines        7176     7176           
  Branches     1318     1318           
=======================================
  Hits         5611     5611           
  Misses       1377     1377           
  Partials      188      188           
Flag Coverage Δ
suite.unit 78.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.19% <ø> (ø)

@Leo10Gama
Copy link
Member Author

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 27, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d97f038
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9f3d09b into main Nov 27, 2024
17 checks passed
@mergify mergify bot deleted the revert-32173-dependabot/github_actions/codecov/codecov-action-5 branch November 27, 2024 18:46
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants