-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rds.DatabaseInstance.fromLookup #32358
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cd packages/@aws-cdk-testing/framework-integ Verifying integration test snapshots... UNCHANGED integ.cluster-dual 1.515s Snapshot Results: Tests: 42 passed, 42 total |
Hi, I touched packages/aws-cdk, but I didn't change any CLI. This is a |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
Issue # (if applicable)
#31720
Reason for this change
Add new rds.DatabaseInstance.fromLookup feature.
This change depends on cdklabs/cloud-assembly-schema#72
Description of changes
Description of how you validated changes
Included these tests:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license