Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial batch failure support with Amazon.Lambda.KinesisEvents #1553

Closed
2 tasks
danny-zegel-zocdoc opened this issue Jul 30, 2023 · 2 comments
Closed
2 tasks

Partial batch failure support with Amazon.Lambda.KinesisEvents #1553

danny-zegel-zocdoc opened this issue Jul 30, 2023 · 2 comments
Assignees
@ashishdhingra
Labels
feature-request A feature should be added or improved. module/lambda-client-lib p2 This is a standard priority issue queued

Comments

@danny-zegel-zocdoc
Copy link

Describe the feature

When processing a kinesis stream configured with reportBatchItemFailures as true I expected to find a StreamsEventResponse object defined in Amazon.Lambda.KinesisEvents so I can report a partial batch failure similar to how Amazon.Lambda.DynamoDBEvents has StreamsEventResponse and Amazon.Lambda.SQSEvents has SQSBatchResponse.

The documentation here https://docs.aws.amazon.com/lambda/latest/dg/with-kinesis.html#services-kinesis-batchfailurereporting indicates that this is already available for Java and I would appreciate this feature added for dotnet.

Use Case

This feature would be appreciated when using a Lambda to process a Kinesis stream that has ReportBatchItemFailures configured to true.

Proposed Solution

Implement StreamsEventResponse in the Amazon.Lambda.KinesisEvents package.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

Amazon.Lambda.KinesisEvents

Targeted .NET Platform

.NET 6 and up

Operating System and version

N/A
@danny-zegel-zocdoc danny-zegel-zocdoc added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 30, 2023
@ashishdhingra ashishdhingra added module/lambda-client-lib p2 This is a standard priority issue needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Jul 31, 2023
@ashishdhingra ashishdhingra self-assigned this Aug 3, 2023
@ashishdhingra ashishdhingra mentioned this issue Aug 3, 2023
Merged
@ashishdhingra
Copy link
Contributor

This has been implemented in Amazon.Lambda.KinesisEvents v2.1.0.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashishdhingra ashishdhingra

Labels
feature-request A feature should be added or improved. module/lambda-client-lib p2 This is a standard priority issue queued
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danny-zegel-zocdoc @ashishdhingra