Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda Annotations can raise CS1591 warning #1727

Closed
chrischappell-rgare opened this issue Apr 12, 2024 · 4 comments
Closed

Lambda Annotations can raise CS1591 warning #1727

chrischappell-rgare opened this issue Apr 12, 2024 · 4 comments
Labels
annotations bug This issue is a bug. p1 This is a high priority issue queued xs Effort estimation: tiny

Comments

@chrischappell-rgare
Copy link

Describe the bug

A CS1591 warning is raised if a Lamba project using Lambda Annotations has documentation file generation enabled. The project will not build at all if it has TreatWarningsAsError enabled.

Expected Behavior

The generated code can use #pragma warning disable CS1591 to prevent the warning from being raised.

Current Behavior

Each public member has warning CS1591: Missing XML comment for publicly visible type or member 'Type_or_Member'.

Reproduction Steps

Add <GenerateDocumentationFile>true</GenerateDocumentationFile> to a project using Amazon.Lambda.Annotations.

Possible Solution

Enclose the generated code in #pragma warning disable CS1591.

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

Amazon.Lambda.Annotations 1.3.0

Targeted .NET Platform

.Net 8

Operating System and version

AmazonLinux

@chrischappell-rgare chrischappell-rgare added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 12, 2024
@ashishdhingra
Copy link
Contributor

Needs review with the team. Probably low hanging fruit.

@ashishdhingra ashishdhingra added needs-review annotations p1 This is a high priority issue xs Effort estimation: tiny and removed needs-triage This issue or PR still needs to be triaged. needs-review labels Apr 15, 2024
@ashishdhingra
Copy link
Contributor

Low hanging fruit P1. Possible related discussion #1733.

@ashishdhingra
Copy link
Contributor

This should have been addressed via PR #1748 and available in Amazon.Lambda.Annotations v1.4.0 package.

Copy link
Contributor

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotations bug This issue is a bug. p1 This is a high priority issue queued xs Effort estimation: tiny
Projects
None yet
Development

No branches or pull requests

2 participants