Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-lc-sys build should check for minimal bindgen version #484

Closed
elmarco opened this issue Aug 5, 2024 · 2 comments
Closed

aws-lc-sys build should check for minimal bindgen version #484

elmarco opened this issue Aug 5, 2024 · 2 comments
Assignees

Comments

@elmarco
Copy link

elmarco commented Aug 5, 2024

During the build of a project that depends on rustls, and includes aws-lc-sys:

bindgen-STDERR: error: invalid value '1.59' for '--rust-target <RUST_TARGET>': Got an invalid rust target. Accepted values are of the form "1.0" or "nightly".

I used to have bindgen 0.65.1 installed.
After upgrading to 0.69.4, issue disappeared.

@justsmth justsmth self-assigned this Aug 5, 2024
@justsmth
Copy link
Contributor

Hello! Thanks for reporting this.

I put up a PR to help improve our handling of this: #494

@justsmth
Copy link
Contributor

justsmth commented Sep 6, 2024

This is resolved with the release of aws-lc-rs v1.9.0.

@justsmth justsmth closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants