Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally disable library error logging #118

Closed
aleybe opened this issue Mar 8, 2020 · 5 comments
Closed

Optionally disable library error logging #118

aleybe opened this issue Mar 8, 2020 · 5 comments
Assignees
Labels
guidance Question that needs advice or information. module/logging needs-triage This issue or PR still needs to be triaged.

Comments

@aleybe
Copy link

aleybe commented Mar 8, 2020

Hey guys,

I have created a PR #117 which adds a property to optionally disable the automatic logging of errors if the Library fails to log to CloudWatch (i.e the IAM credentials doesn't have access).

The reason I have created this PR; in the past if I have used this library on a service which was running on a server and something has happened it can cause the error logs to start to fill up the installation directory.

A better method would be to have some kind log roll-over, but I have just quickly added this boolean on/off instead.

Let me know your thoughts. I can put a bit more time into this next week for log rollover. This is similar to an existing issue #80 and the work around was to set an empty string in the "LibraryLogFileName" property. I feel that having this additional property might be a bit more suitable as it's much clearer what it's objective is within the library.

Looking forward to hearing from you, all feedback is welcome :)

Thanks guys, this library is incredibly useful I appreciate all your heavy lifting ❤️

@klaytaybai klaytaybai added the needs-triage This issue or PR still needs to be triaged. label Mar 9, 2020
@MarcelChirtes
Copy link

Can this be resolved? was reported last year #80

@MarcelChirtes
Copy link

MarcelChirtes commented Jun 3, 2020

Or give an alternative to stop it.

@MarcelChirtes
Copy link

MarcelChirtes commented Jun 3, 2020

No more issue, found it, by setting LibraryLogFileName to null no log happens

@ashishdhingra ashishdhingra added module/logging guidance Question that needs advice or information. labels Jul 31, 2020
@ashishdhingra
Copy link
Contributor

Hi @aleybe,

Good afternoon.

Please confirm if the workaround provided by @MarcelChirtes works for you.

Thanks,
Ashish

@ashishdhingra ashishdhingra added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jul 31, 2020
@ashishdhingra ashishdhingra self-assigned this Jul 31, 2020
@aleybe
Copy link
Author

aleybe commented Aug 2, 2020

hi @ashishdhingra this can be closed, it was more or less an issue to address the PR #117
just some additional functionality to make the user experience a little friendlier :)

Thanks,
Alex

@ashishdhingra ashishdhingra added closing-soon This issue will automatically close in 4 days unless further comments are made. and removed response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. closing-soon This issue will automatically close in 4 days unless further comments are made. labels Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information. module/logging needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

4 participants