Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NLog 5.x #225

Open
1 of 2 tasks
rgtek opened this issue Aug 2, 2023 · 1 comment
Open
1 of 2 tasks

Support NLog 5.x #225

rgtek opened this issue Aug 2, 2023 · 1 comment
Labels
feature-request A feature should be added or improved. module/logging p2 This is a standard priority issue queued

Comments

@rgtek
Copy link

rgtek commented Aug 2, 2023

Describe the feature

NLog 5.2 was released on May 30, 2023. Changelog: https://github.com/NLog/NLog/releases/tag/v5.2.0

AWS.Logger.NLog currently supports up to NLog 4.7.15

The new major version of NLog (5.0) does come with breaking changes.

Use Case

Aiming to keep up with the latest releases to leverage any security patches and leverage performance improvements in our current developments using NLog as a dependency.

Proposed Solution

Update the dependency to the NLog 5.2.2 and address any breaking changes.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

AWS.Logger.NLog v3.1

Targeted .NET Platform

.NET Framework 4.8, .NET 6

Operating System and version

AmazonLinux, Windows 10

@rgtek rgtek added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 2, 2023
@ashishdhingra
Copy link
Contributor

Needs review with the team taking note of breaking changes.

@ashishdhingra ashishdhingra added needs-review p2 This is a standard priority issue queued and removed needs-triage This issue or PR still needs to be triaged. needs-review labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/logging p2 This is a standard priority issue queued
Projects
None yet
Development

No branches or pull requests

2 participants