Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose option to not do an etcd quorum read when listing pods on a node #1017

Closed
hieurender opened this issue May 29, 2024 · 1 comment
Closed
Labels
Type: Enhancement New feature or request

Comments

@hieurender
Copy link
Contributor

Describe the feature
The fetchAllPods function currently lists all pods in such a way that it requires etcd to do a quorum read out of all pods in the cluster, and pass that (potentially very large) list to the k8s apiserver, who then selects only the ones with the desired spec.nodeName field. In very large clusters, this can be slow operation that's arduous for etcd to execute.

A less expensive way of achieving the same thing would be to leverage the apiserver cache, which indexes pods by their node name. This can be done by passing a non-empty ResourceVersion in the metav1.ListOptions.

I would like the nthConfig to expose a flag to configure this behavior, with the status quo being the default, since most users seem to be happy with a consistent read.

The situation is very similar to this issue in the vector project, which was fixed by this PR.

Is the feature request related to a problem?
A description of what the problem is. For example: I'm frustrated when [...]

Describe alternatives you've considered
A description of any alternative solutions or features you've considered.

@LikithaVemulapalli
Copy link
Contributor

Support for this issue is now merged, closing this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants