Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deadline): adding deadline version check for workers #100

Merged
merged 7 commits into from
Sep 18, 2020

Conversation

yashda
Copy link
Contributor

@yashda yashda commented Aug 28, 2020

While configuring deadline workers if the installed deadline
client version is less than the minimum supported deadline version
then we now fail during deployment.

Also updating the deadline readme.

Verified by installing a higher and lower versions for both
windows and linux.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

While configuring deadline workers if the installed deadline
client version is less than the minimum supported deadline version
then we now fail during deployment.

Also updating the deadline readme.

Verified by installing a higher and lower versions for both
windows and linux.
@grbartel grbartel added the contribution/core This is a PR that came from AWS. label Aug 28, 2020
@jusiskin jusiskin requested review from jusiskin and horsmand August 31, 2020 15:45
horsmand
horsmand previously approved these changes Aug 31, 2020
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor suggestions, but otherwise this will be great and could save a lot of potential headaches. Great stuff!

packages/aws-rfdk/lib/deadline/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. One last suggested change

Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just about ready. Just a minor question about the TSDoc warning added.

packages/aws-rfdk/lib/deadline/lib/worker-fleet.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@yashda yashda requested a review from horsmand September 18, 2020 13:41
@horsmand horsmand merged commit 291f903 into aws:mainline Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants