fix(examples): Fix instructions and formatting in example app README #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes aws#105 - The python example app README gave instructions for using the TypeScript `UsageBasedLicense` API. Fixed to use the python API. - Also fix up formatting in README markdown for both example app languages
kozlove-aws
reviewed
Aug 31, 2020
examples/deadline/All-In-AWS-Infrastructure-Basic/python/README.md
Outdated
Show resolved
Hide resolved
yashda
suggested changes
Aug 31, 2020
examples/deadline/All-In-AWS-Infrastructure-Basic/python/README.md
Outdated
Show resolved
Hide resolved
kozlove-aws
approved these changes
Sep 8, 2020
jusiskin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Fixes #105
Changes
UsageBasedLicenseAPI. Fixed to use the python API.Testing
Visually inspected the rendered markdown in VSCode's and GitHub's rendered markdown
Confirmed that the example APIs mentioned in the docs work properly using RFDK python packages:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license