Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update MongoDB version to 8.0 #1392

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

marofke
Copy link
Contributor

@marofke marofke commented Dec 3, 2024

Problem

The default version of MongoDB installed by RFDK is 3.6, which became end of life quite a long time ago https://www.mongodb.com/legal/support-policy/lifecycles

Solution

Remove support for MongoDB 3.6 and add support for 8.0 by default (this is the latest version of MongoDB at this time). This required a few tweaks since the API changed. Also, I noticed the Node JS mongodb driver was quite old as well, so that's been bumped to the latest version.

Finally, I added ap-southeast-5 to our denylist of regions for the lambda-layers package, as it's not enabled by default and is a new region since the last time we updated it.

Testing

  • ran integration tests, confirmed they all passed, also ran with the parallel flag set to true and confirmed they passed
    • I noticed the integration test directory wasn't being cleaned up properly, as I was left with a stale staged directory when running yarn clean. I've updated the cleanup script to remove all generated directories for integration tests (just run yarn clean from the root of the package)
  • I did an upgrade test simulating an existing customer setup before these changes:
    • deployed the All-In-AWS-Infrastructure-Basic example with the current mainline changes
      • I did a yarn clean && git clean -fxd to ensure I had a clean environment
    • I then SSM'd onto the MongoDB instance and confirmed it was on version 3.6
    • I SSM'd onto the Worker instance and submitted a job:
      • ./deadlinecommand.exe -SubmitCommandLineJob -executable "/bin/sleep" -arguments "5" -frames 1-10 -priority 50 -name "Test Job2"
      • confirmed it showed up with ./deadlinecommand.exe -GetJobs
    • then, I checked out the changes from this PR and deployed them overtop my existing deployment
      • I did a yarn clean && git clean -fxd to ensure I had a clean environment
    • I SSM'd onto the DB instance and confirmed he existing Mongo 3.6 database was retained and it was not upgraded to 8.0. I confirmed my existing jobs were in the DB and I could submit new jobs from the Worker instance still
  • followed the readme to publish lambda-layers to my account, confirming it succeeded

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@marofke marofke force-pushed the marofke/mongo8.0 branch 2 times, most recently from 7aa019d to ef65da0 Compare December 4, 2024 16:56
jgaudet-aws
jgaudet-aws previously approved these changes Dec 4, 2024
@marofke marofke force-pushed the marofke/mongo8.0 branch 2 times, most recently from 36700cb to 6358777 Compare December 4, 2024 20:20
Remove support for MongoDB 3.6 and adds support for 8.0.

Signed-off-by: Caden Marofke <132690522+marofke@users.noreply.github.com>
@jgaudet-aws jgaudet-aws merged commit 88dbeb0 into aws:mainline Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants