feat(deadline): versionquery construct #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horsmand
changed the title
horsmand
changed the title
horsmand
changed the title
horsmand
force-pushed
the
version-query
branch
from
e3ab9fa
to
fad2e80
Compare
horsmand
commented
Oct 15, 2020
examples/deadline/All-In-AWS-Infrastructure-Basic/python/package/lib/service_tier.py
Outdated
Show resolved
Hide resolved
ddneilson
requested changes
Oct 15, 2020
horsmand
force-pushed
the
version-query
branch
from
fad2e80
to
47489d3
Compare
ddneilson
requested changes
Oct 23, 2020
packages/aws-rfdk/lib/core/lambdas/nodejs/version-provider/handler.ts
Outdated
Show resolved
Hide resolved
packages/aws-rfdk/lib/core/lambdas/nodejs/lib/version-provider/index.ts
Outdated
Show resolved
Hide resolved
examples/deadline/All-In-AWS-Infrastructure-Basic/python/package/lib/service_tier.py
Outdated
Show resolved
Hide resolved
integ/components/deadline/deadline_01_repository/bin/deadline_01_repository.ts
Outdated
Show resolved
Hide resolved
horsmand
force-pushed
the
version-query
branch
from
47489d3
to
ed9afc9
Compare
yashda
reviewed
Oct 29, 2020
examples/deadline/All-In-AWS-Infrastructure-Basic/python/README.md
Outdated
Show resolved
Hide resolved
examples/deadline/All-In-AWS-Infrastructure-Basic/python/README.md
Outdated
Show resolved
Hide resolved
integ/components/deadline/deadline_01_repository/bin/deadline_01_repository.ts
Outdated
Show resolved
Hide resolved
ddneilson
previously approved these changes
Nov 5, 2020
| versionString: props?.version, | ||
| // If we don't have a full static version string, create a random string that will force the Lambda to always | ||
| // run on redeploys, effectively checking for version updates. | ||
| forceRun: this.forceRun(props?.version), |
There was a problem hiding this comment.
I like the way you did this!
yashda
previously approved these changes
Nov 5, 2020
yashda
previously approved these changes
Nov 5, 2020
ddneilson
approved these changes
Nov 5, 2020
yashda
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176
This was tested by successfully deploying the TypeScript and Python example apps, and running the integration tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license