feat(core): Add configurable expiry to X.509 certificates #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddneilson
force-pushed
the
x509_expiry
branch
from
400294d to
a0ebe36
Compare
horsmand
previously approved these changes
Nov 25, 2020
jusiskin
requested changes
Nov 26, 2020
packages/aws-rfdk/lib/lambdas/nodejs/lib/x509-certs/test/certificate.test.ts
Show resolved
Hide resolved
packages/aws-rfdk/lib/lambdas/nodejs/lib/x509-certs/test/certificate.test.ts
Show resolved
Hide resolved
ddneilson
force-pushed
the
x509_expiry
branch
from
a0ebe36 to
9add07f
Compare
ddneilson
force-pushed
the
x509_expiry
branch
from
9add07f to
58ca23d
Compare
jusiskin
approved these changes
Nov 26, 2020
horsmand
approved these changes
Nov 26, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: #241
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license