fix(integ): Support last changes in Deadline 10.1.11 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grbartel
suggested changes
Nov 24, 2020
| @@ -111,6 +111,7 @@ export abstract class RenderQueueConnection { | |||
| 'if [ -f "/etc/profile.d/deadlineclient.sh" ]; then', | |||
| ' source "/etc/profile.d/deadlineclient.sh"', | |||
| 'fi', | |||
| '"\${DEADLINE_PATH}/deadlinecommand" -SetIniFileSetting LaunchSlaveAtStartup True', | |||
There was a problem hiding this comment.
We do not want to set this here. This class is a generic class used to set up any deadline isntance being able to connect to a render queue not specifically workers as such your changes make it so any Workstation, Pulse or other component automatically starts up workers.
This setting is also already being set in the ConfigureWorker.sh which is where I would expect all of this code to exist.
There was a problem hiding this comment.
After offline discussion we have found a way not to start worker before configuration Pools and Groups.
| @@ -122,6 +123,7 @@ export abstract class RenderQueueConnection { | |||
| host.userData.addCommands( | |||
| '$ErrorActionPreference = "Stop"', | |||
| '$DEADLINE_PATH = (get-item env:"DEADLINE_PATH").Value', | |||
| '& "$DEADLINE_PATH/deadlinecommand.exe" -SetIniFileSetting LaunchSlaveAtStartup True | Out-Default', | |||
There was a problem hiding this comment.
Same as Above this class should have no Worker specific code in it.
ryyakobe
reviewed
Nov 24, 2020
integ/components/deadline/deadline_03_workerFleetHttp/test/deadline_03_workerFleetHttp.test.ts
Outdated
Show resolved
Hide resolved
kozlove-aws
force-pushed
the
fix_integ_workers
branch
2 times, most recently
from
abe3e49
to
0ecde17
Compare
ryyakobe
previously approved these changes
Nov 25, 2020
ddneilson
reviewed
Nov 25, 2020
integ/components/deadline/deadline_03_workerFleetHttp/test/deadline_03_workerFleetHttp.test.ts
Outdated
Show resolved
Hide resolved
grbartel
previously approved these changes
Nov 25, 2020
kozlove-aws
force-pushed
the
fix_integ_workers
branch
from
0ecde17
to
415064c
Compare
ddneilson
approved these changes
Nov 25, 2020
ryyakobe
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The last Deadline 10.1.11 brings some changes that make RFDK integration tests fail.
DeadlineLauncherright after start leads to worker continue without last changes indeadline.iniSolution
unrecognizedregion instead oftestregionTesting
For testing were ran integration tests and make sure that all tests passed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license