feat(deadline): configure worker log listener port #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horsmand
commented
Dec 4, 2020
ddneilson
requested changes
Dec 9, 2020
| @@ -178,16 +186,23 @@ export interface WorkerInstanceConfigurationProps { | |||
| * environments. | |||
| */ | |||
| export class WorkerInstanceConfiguration extends Construct { | |||
| private static readonly DEFAULT_WORKER_PORT = 56032; | |||
There was a problem hiding this comment.
Curious... randomly selected? Or is this a standard port for Deadline?
There was a problem hiding this comment.
This was a random selection, from what I've seen Deadline always randomizes this port. I couldn't find any other common software using this port and it's in the dynamic port range defined by IANA.
| @@ -178,16 +186,23 @@ export interface WorkerInstanceConfigurationProps { | |||
| * environments. | |||
| */ | |||
| export class WorkerInstanceConfiguration extends Construct { | |||
| private static readonly DEFAULT_WORKER_PORT = 56032; | |||
|
|
|||
| public readonly logListenerPort: number; | |||
There was a problem hiding this comment.
This should have a docstring.
ddneilson
previously approved these changes
Dec 11, 2020
kozlove-aws
reviewed
Dec 11, 2020
packages/aws-rfdk/lib/deadline/test/worker-configuration.test.ts
Outdated
Show resolved
Hide resolved
kozlove-aws
reviewed
Dec 11, 2020
Fixes #190 Either a default port or a user supplied port will be configured for all workers to listen on, for remote requests such as requsting their log stream. A helper method is also provided to open up the port in the worker fleet's security group to any provided IConnectable, like another security group or a CIDR.
kozlove-aws
approved these changes
Dec 11, 2020
ddneilson
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190
Either a default port or a user supplied port will be configured for all
workers to listen on, for requests for their log stream. A helper method
is also provided to open up the port in the worker fleet's security
group to any provided IConnectable, like another security group or a CIDR.
Testing
I followed these steps for testing:
a. Added a Windows worker fleet added alongside the Linux fleet.
b. Opened up the worker log listener ports in both fleets for the CIDR
10.0.0.0/24.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license