feat(deadline): add security group configuration for Repository and RenderQueue #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jericht
force-pushed
the
jericht/expand_security_group_config
branch
5 times, most recently
from
73c3c83
to
eb2878f
Compare
jericht
force-pushed
the
jericht/expand_security_group_config
branch
2 times, most recently
from
3425e70
to
e67d618
Compare
kozlove-aws
reviewed
Feb 24, 2021
| /** | ||
| * Options to add additional security groups to the `RenderQueue`. | ||
| */ | ||
| readonly securityGroups?: RenderQueueSecurityGroupsOptions; |
There was a problem hiding this comment.
How about more informative variable name?
Like securityGroupsOptions.
ddneilson
requested changes
Feb 24, 2021
| /** | ||
| * The `AutoScalingGroup` security groups. | ||
| */ | ||
| readonly autoScalingGroup?: ISecurityGroup[]; |
There was a problem hiding this comment.
-
Maybe name these
backendandfrontendinstead?frontend-> Security group for the load balancer.backend-> Security group for everything behind the load balancer. It's probable that we add the Deadline WebService to this same construct, and it makes some sense for it to have the same SG as the RCS. -
The normal pattern in CDK constructs is to accept a single
ISecurityGroupas a construct property, rather than an array, and then expose anaddSecurityGroups()method. What do you think about following that pattern here?
There was a problem hiding this comment.
Sounds good, updated
jericht
force-pushed
the
jericht/expand_security_group_config
branch
from
e67d618
to
4fd6663
Compare
ddneilson
previously approved these changes
Feb 26, 2021
kozlove-aws
reviewed
Feb 26, 2021
jericht
force-pushed
the
jericht/expand_security_group_config
branch
from
b399e39
to
c557523
Compare
ddneilson
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #307
Changes
RenderQueue: AddaddSecurityGroupsmethod that adds security groups to theAutoScalingGroup,LoadBalancer, or both.Repository: AddaddSecurityGroupmethod that adds security groups to theDatabaseConnection.DatabaseConnectionCfnDBCluster.MongoDbInstance: Added anaddSecurityGroupmethod to add security groups to theAutoScalingGroupof theStaticPrivateIpServer.Testing
SecurityGroupinStorageTierand added it to theRepositoryconstruct in theServiceTier.SecurityGroupinServiceTierand added it to theRenderQueueconstruct in theServiceTier.Repository(DocDB): Added to the DocDB ClusterRepository(MongoDB): Added to the AutoScalingGroupRenderQueue: Added to the AutoScalingGroup and LoadBalanceraddSecurityGroup(s)methods to add security groupsaddSecurityGroup(s)methods to add security groupsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license