feat(deadline): add security group property to ubl #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jericht
approved these changes
Apr 19, 2021
ddneilson
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394
Notes
This PR adds
securityGroupas a construct property on the UBL construct to be used by the ASG that gets created to host the container running the license forwarder, similarly to how we accept asecurityGroupon the RenderQueue construct for the same purpose.Testing
A unit test was added to pass a security group into the UBL constructor and confirm that the security group's ID was present in the LaunchConfiguration of the ASG that the UBL construct creates.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license