Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): increase lambda timeout for X509Certificate* constructs #476

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

jusiskin
Copy link
Contributor

Problem

Fixes #475

A customer reported experiencing deployment failures related to the X509CertificatePem construct. The Lambda timed out and the Cfn response was not received.

Solution

Increase the Lambda function timeout for the X509CertificatePem and X509CertificatePkcs constructs.

Testing

  • Deployed the All-in-AWS-Infrastructure-Basic example app
  • Confirmed the Lambda functions for the X509Certificate* constructs are deployed with 90 second timeouts
  • Confirmed none of the custom resources time out

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin added the contribution/core This is a PR that came from AWS. label Jun 17, 2021
Copy link
Contributor

@horsmand horsmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
3 participants