feat(deadline): add Secret Management support for Repository #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlove-aws
force-pushed
the
use_sm_for_repository
branch
from
f62b3a3
to
a35f117
Compare
kozlove-aws
changed the title
kozlove-aws
changed the title
kozlove-aws
changed the title
kozlove-aws
force-pushed
the
use_sm_for_repository
branch
2 times, most recently
from
8241a11
to
a97c6e4
Compare
kozlove-aws
changed the title
kozlove-aws
changed the title
kozlove-aws
force-pushed
the
use_sm_for_repository
branch
from
a97c6e4
to
db337ff
Compare
kozlove-aws
changed the title
kozlove-aws
changed the title
horsmand
reviewed
Aug 3, 2021
packages/aws-rfdk/lib/deadline/scripts/bash/installDeadlineRepository.sh
Outdated
Show resolved
Hide resolved
kozlove-aws
force-pushed
the
use_sm_for_repository
branch
from
db337ff
to
c6e4eb8
Compare
horsmand
suggested changes
Aug 5, 2021
jericht
requested changes
Aug 5, 2021
packages/aws-rfdk/lib/deadline/scripts/bash/installDeadlineRepository.sh
Outdated
Show resolved
Hide resolved
jusiskin
changed the title
horsmand
suggested changes
Aug 9, 2021
packages/aws-rfdk/lib/deadline/scripts/bash/installDeadlineRepository.sh
Outdated
Show resolved
Hide resolved
packages/aws-rfdk/lib/deadline/scripts/bash/installDeadlineRepository.sh
Outdated
Show resolved
Hide resolved
packages/aws-rfdk/lib/deadline/scripts/bash/installDeadlineRepository.sh
Outdated
Show resolved
Hide resolved
jericht
requested changes
Aug 10, 2021
packages/aws-rfdk/lib/deadline/scripts/bash/installDeadlineRepository.sh
Outdated
Show resolved
Hide resolved
horsmand
reviewed
Aug 11, 2021
kozlove-aws
force-pushed
the
use_sm_for_repository
branch
7 times, most recently
from
2fbc8cf
to
edd489d
Compare
jericht
requested changes
Aug 12, 2021
packages/aws-rfdk/lib/deadline/scripts/bash/installDeadlineRepository.sh
Outdated
Show resolved
Hide resolved
kozlove-aws
force-pushed
the
use_sm_for_repository
branch
from
edd489d
to
3aa92fa
Compare
kozlove-aws
changed the base branch from
mainline
to
feature_enable_secret_manager
horsmand
suggested changes
Aug 13, 2021
kozlove-aws
force-pushed
the
use_sm_for_repository
branch
from
3aa92fa
to
08bcae4
Compare
horsmand
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need to have possibility to enable Secret Management in repository construct, also Secret Management should be enabled by default.
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license