fix(deadline): fix issue in client TLS configuration for Deadline 10.1.18.5 #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I applied a fix to this draft PR to get the integ tests to pass, so I've created a new PR from my fork.
Problem
The behavior of the
ChangeRepository[SkipValidation]
Deadline command in 10.1.18.5 has changed. It now clears theProxySSLCA
setting indeadline.ini
before attempting to apply/validate the configuration. RFDK relied on the previous behavior where theProxySSLCA
was left unchanged.Solution
We cannot use
ChangeRepository
without supplying a "client certificate" since this will disable TLS. Instead, we have switched from usingChangeRepository
to instead useSetIniFileSetting ProxyRoot <RQ_ENDPOINT>
. RFDK also relied on havingChangeRepository
validate the connection and error if the connection settings were incorrect. We now change that validation to instead run a separate Deadline command to test the connection.We made the same change to the Deadline configuration script that runs on the RFDK integ tests.
Testing
The RFDK integ tests are now passing using the Deadline Client 10.1.18.5 to stage the Docker recipes and the
Deadline Worker Base Image Windows 10.1.18.5 2021-07-30T215517Z - ami-0d5da435a9d85896b
AMI for the worker fleets.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license