Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deadline): fix issue in client TLS configuration for Deadline 10.1.18.5 #543

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

horsmand
Copy link
Contributor

I applied a fix to this draft PR to get the integ tests to pass, so I've created a new PR from my fork.

Problem

The behavior of the ChangeRepository[SkipValidation] Deadline command in 10.1.18.5 has changed. It now clears the ProxySSLCA setting in deadline.ini before attempting to apply/validate the configuration. RFDK relied on the previous behavior where the ProxySSLCA was left unchanged.

Solution

We cannot use ChangeRepository without supplying a "client certificate" since this will disable TLS. Instead, we have switched from using ChangeRepository to instead use SetIniFileSetting ProxyRoot <RQ_ENDPOINT> . RFDK also relied on having ChangeRepository validate the connection and error if the connection settings were incorrect. We now change that validation to instead run a separate Deadline command to test the connection.

We made the same change to the Deadline configuration script that runs on the RFDK integ tests.

Testing

The RFDK integ tests are now passing using the Deadline Client 10.1.18.5 to stage the Docker recipes and the Deadline Worker Base Image Windows 10.1.18.5 2021-07-30T215517Z - ami-0d5da435a9d85896b AMI for the worker fleets.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

jericht
jericht previously approved these changes Aug 26, 2021
@ddneilson ddneilson self-requested a review August 27, 2021 14:25
@jericht jericht merged commit 05b14f9 into aws:mainline Aug 27, 2021
@jusiskin jusiskin added the bug This issue is a bug. label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants