Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deadline): validate minimum Deadline version for secrets management #573

Merged
merged 2 commits into from
Oct 21, 2021
Merged

feat(deadline): validate minimum Deadline version for secrets management #573

merged 2 commits into from
Oct 21, 2021

Conversation

kozlove-aws
Copy link
Contributor

Problem

Deadline fully support all changes in RFDK only from version 10.1.19.0.
We need to validate that Deadline Secret management is enabled only from this version

Solution

  • Moved constant with minimum version for secret management in Version
  • Updated min version to 10.1.19.0
  • Added version validation in Repository construct.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin added the contribution/core This is a PR that came from AWS. label Sep 21, 2021
@horsmand horsmand self-requested a review September 21, 2021 22:19
@jusiskin jusiskin changed the title Min Deadline version validation for Secret Management in Repository feat(deadline): validate minimum Deadline version for secrets management Sep 22, 2021
horsmand
horsmand previously approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@horsmand horsmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a commit to remove one extra blank line because that was the only issue I saw left and wanted to save the extra iteration on the review just to remove it. Everything looks good to me now.

jusiskin
jusiskin requested changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor test semantic. Otherwise this looks great.

packages/aws-rfdk/lib/deadline/test/repository.test.ts Outdated Show resolved Hide resolved
@jusiskin jusiskin marked this pull request as draft September 24, 2021 17:00
jusiskin
jusiskin previously approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go. We'll need to wait until the minimum Deadline version is released before we can merge (with a possible rebase required).

@horsmand horsmand mentioned this pull request Oct 12, 2021
Merged
@kozlove-aws kozlove-aws changed the base branch from feature_enable_secret_manager to mainline October 18, 2021 16:56
@kozlove-aws kozlove-aws dismissed jusiskin’s stale review October 18, 2021 16:56

The base branch was changed.

@horsmand horsmand marked this pull request as ready for review October 21, 2021 14:38
horsmand
horsmand suggested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@horsmand horsmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release is out and the version number is 10.1.19.4 so let's just bump the min version to that.

packages/aws-rfdk/lib/deadline/lib/version.ts Show resolved Hide resolved
packages/aws-rfdk/lib/deadline/test/repository.test.ts Outdated Show resolved Hide resolved
@jusiskin jusiskin merged commit 6d5950e into aws:mainline Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jusiskin jusiskin jusiskin approved these changes

@horsmand horsmand horsmand approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kozlove-aws @horsmand @jusiskin