Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deadline): update to Deadline licensing terms #742

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

ddneilson
Copy link
Contributor

@ddneilson ddneilson commented Jul 28, 2022

BREAKING CHANGE: The userAwsThinkboxEulaAcceptance property of the ThinkboxDockerImages
construct has been removed and replaced with userAwsCustomerAgreementAndIpLicenseAcceptance.
The licensing terms of Deadline have been retroactively changed with the
release of Deadline 10.1.23, and these new terms must be agreed to by a
code change in your applications.


Note: The BREAKING CHANGE text as it appears in the commit will appear in the release notes / ChangeLog.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@ddneilson ddneilson requested review from kozlove-aws and jericht July 28, 2022 17:46
@ddneilson
Copy link
Contributor Author

New revision incoming. This is a breaking change, but I neglected to indicate as such in the commit message. It's important for the ChangeLog.

Copy link
Contributor

@kozlove-aws kozlove-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple suggestions.

Copy link
Contributor

@kozlove-aws kozlove-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some more comments similar that were fixed.

examples/deadline/EC2-Image-Builder/python/README.md Outdated Show resolved Hide resolved
examples/deadline/Local-Zone/python/README.md Outdated Show resolved Hide resolved
packages/aws-rfdk/lib/deadline/README.md Outdated Show resolved Hide resolved
packages/aws-rfdk/lib/deadline/README.md Outdated Show resolved Hide resolved
packages/aws-rfdk/lib/deadline/README.md Outdated Show resolved Hide resolved
@ddneilson ddneilson force-pushed the update_tb_eula branch 5 times, most recently from d4f8f8a to cd5f3af Compare July 28, 2022 21:47
BREAKING CHANGE: The `userAwsThinkboxEulaAcceptance` property of the `ThinkboxDockerImages`
construct has been removed and replaced with `userAwsCustomerAgreementAndIpLicenseAcceptance`.
The licensing terms of Deadline have been retroactively changed with the
release of Deadline 10.1.23, and these new terms must be agreed to by a
code change in your applications.
Copy link
Contributor

@jericht jericht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddneilson ddneilson merged commit 03bc8ee into aws:mainline Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants