Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Makefile? #40

Closed
mhart opened this issue Aug 14, 2017 · 1 comment
Closed

Missing Makefile? #40

mhart opened this issue Aug 14, 2017 · 1 comment
Labels
contributors/welcome Contributors are welcome to work on this

Comments

@mhart
Copy link
Contributor

mhart commented Aug 14, 2017

CONTRIBUTING.md says:

You may run all test by either running the make test target (requires go, and go cover to be installed).

But there's no Makefile so make test just exits with:

make: Nothing to be done for `test'.`
@sanathkr
Copy link
Contributor

We don't use make files. That guide is wrong. Use go get <url> to pull the code, and go test to run tests.

Can you send a PR fixing this?

@PaulMaddox PaulMaddox mentioned this issue Aug 14, 2017
Merged
@sanathkr sanathkr added the contributors/welcome Contributors are welcome to work on this label Jan 7, 2018
@IamFlowZ IamFlowZ mentioned this issue Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributors/welcome Contributors are welcome to work on this
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhart @sanathkr