Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in TransferService #197

Closed
staalezh opened this issue Sep 20, 2016 · 2 comments
Closed

Race condition in TransferService #197

staalezh opened this issue Sep 20, 2016 · 2 comments

Comments

@staalezh
Copy link

I found a race condition in TransferService when using different AmazonS3-client objects. TransferService has an AmazonS3-member which is assigned to in onStartCommand, and is used in execCommand to initiate a transfer:

transfer.start(s3, dbUtil, updater, networkInfoReceiver);

If two transfers are initiated around the same time, onStartCommand may be invoked twice before execCommand is invoked for the first time, and TransferRecord will use the wrong AmazonS3 client.

In my case I had sub-classed AmazonS3Client to use SSE with S3, and as a result, the wrong encryption key was used in the transfer when the race condition kicked in.

@karthiksaligrama
Copy link
Contributor

Thanks will fix this in next release

@karthiksaligrama
Copy link
Contributor

Fixed with 2.3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants