Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparent inability to use library with Windows GUI applications #2573

Closed
hthompson6 opened this issue Jul 12, 2023 · 4 comments · Fixed by #2589
Closed

Apparent inability to use library with Windows GUI applications #2573

hthompson6 opened this issue Jul 12, 2023 · 4 comments · Fixed by #2589
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@hthompson6
Copy link

hthompson6 commented Jul 12, 2023

Describe the bug

Due to the decision made in this thread #402, this line https://github.com/aws/aws-sdk-cpp/blob/main/src/aws-cpp-sdk-core/include/aws/core/client/AWSError.h#L16 was added.

The addition of this line means that one ostensibly cannot use this SDK with Windows GUI applications as it not only breaks the main GetMessage found in most apps but also others invoked in the ATL libraries.

Expected Behavior

I'd expect that both libraries were compatible.

Current Behavior

They are not compatible.

Reproduction Steps

Use the AWS SDK and Windows GUI.

Possible Solution

Rename the AWSError.h method

Additional Information/Context

I'd love a work around for this if anyone has one.

AWS CPP SDK version used

1.11.117

Compiler and Version used

Visual Studio

Operating System and version

Windows 11 Pro

@hthompson6 hthompson6 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2023
@jmklix jmklix self-assigned this Jul 13, 2023
@jmklix jmklix added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jul 13, 2023
@jmklix
Copy link
Member

jmklix commented Jul 13, 2023

Looking into possible work arounds for this that will allow compatibility of Windows GUI applications and this sdk

@jmklix jmklix mentioned this issue Jul 20, 2023
11 tasks
@jmklix jmklix linked a pull request Jul 20, 2023 that will close this issue
11 tasks
@jmklix jmklix added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 20, 2023
@jmklix
Copy link
Member

jmklix commented Jul 20, 2023

I have made a PR with a possible fix for this issue. Testing it to make sure it works without breaking anything else

@hthompson6
Copy link
Author

Awesome thank you!

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants