Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Region Constant in Aws::Region (AP_NORTHEAST_4) & Missing Region Constant (AP_SOUTHEAST_4) #3057

Closed
James-02 opened this issue Jul 26, 2024 · 2 comments · Fixed by #3059
Assignees
Labels
bug This issue is a bug. p1 This is a high priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@James-02
Copy link

James-02 commented Jul 26, 2024

Describe the bug

Within Aws::Region there is a constant AP_NORTHEAST_4, which translates to ap-northeast-4, however this is not an actual region available in AWS: https://docs.aws.amazon.com/general/latest/gr/s3.html

Expected Behavior

The AP_NORTHEAST_4 constant should actually be AP_SOUTHEAST_4, mapping to ap-southeast-4

Current Behavior

The AP_NORTHEAST_4 constant is an invalid region and the AP_SOUTHEAST_4 constant does not exist

Reproduction Steps

#include <aws/core/Aws.h>

std::cout << Aws::Region::AP_NORTHEAST_4 << std::endl;

Possible Solution

Rename the invalid constant to AP_SOUTHEAST_4 and it's string value to ap-southeast-4

Additional Information/Context

No response

AWS CPP SDK version used

1.11.352

Compiler and Version used

gcc (GCC) 11.4.1 20231218 (Red Hat 11.4.1-3)

Operating System and version

Rocky Linux 9.3

@James-02 James-02 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 26, 2024
@sbiscigl
Copy link
Contributor

Yep thats what we get for hand editing it, created a PR to code generate the enum based on the regions defined in parititons.json. Will merge on monday pending any action items on the PR. Thanks for the issue!

@jmklix jmklix linked a pull request Jul 26, 2024 that will close this issue
11 tasks
@jmklix jmklix added pending-release This issue will be fixed by an approved PR that hasn't been released yet. p1 This is a high priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jul 26, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1 This is a high priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants