Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enums conflicting with macros defined in windows kits #3120

Closed
githubpilot123 opened this issue Sep 20, 2024 · 4 comments · Fixed by #3129
Closed

enums conflicting with macros defined in windows kits #3120

githubpilot123 opened this issue Sep 20, 2024 · 4 comments · Fixed by #3129
Labels
bug This issue is a bug. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@githubpilot123
Copy link

Describe the bug

Some enums in aws/core/http/Version.h like "HTTP_VERSION_1_0", "HTTP_VERSION_1_1" are conflicting with macros defined in the windows kits C:\Program Files (x86)\Windows Kits\10\Include\10.0.22621.0\um\http.h

AWS SDK:
image

Windows Kits:
image

My cpp project has to use both the Windows Kits and the AWS SDK. How can I resolve this conflict?

Expected Behavior

My cpp project can use both Windows Kits and AWS c++ SDK without any compile error from this conflict

Current Behavior

compiler will raise error about conflicting enum and macro (HTTP_VERSION_1_0 being one example)

Reproduction Steps

Create any c++ project that uses both windows kits and the cpp AWS SDK, compiler will raise error about conflicting enum and macro (HTTP_VERSION_1_0 being one example)

Possible Solution

No response

Additional Information/Context

No response

AWS CPP SDK version used

1.11.352

Compiler and Version used

19.39.33523

Operating System and version

Windows 10 Enterprise 22H2 19045.4780

@githubpilot123 githubpilot123 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 20, 2024
@jmklix
Copy link
Member

jmklix commented Sep 25, 2024

Working on a fix for this to prevent the initialization on windows systems

@jmklix jmklix added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Sep 25, 2024
@jmklix
Copy link
Member

jmklix commented Sep 25, 2024

Testing this fix: #3129

@jmklix jmklix added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Sep 25, 2024
@jmklix jmklix linked a pull request Sep 25, 2024 that will close this issue
11 tasks
@jmklix jmklix mentioned this issue Sep 27, 2024
11 tasks
@jmklix jmklix removed a link to a pull request Sep 30, 2024
11 tasks
@jmklix jmklix linked a pull request Sep 30, 2024 that will close this issue
11 tasks
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@jmklix
Copy link
Member

jmklix commented Sep 30, 2024

Please let us know if you still have any problems while trying to use the windows kits along with this sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants