Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 Client does not send Expect: 100-continue header for HTTP PUT requests #1451

Closed
skmcgrail opened this issue Oct 7, 2021 · 2 comments
Closed

S3 Client does not send Expect: 100-continue header for HTTP PUT requests #1451

skmcgrail opened this issue Oct 7, 2021 · 2 comments
Assignees
@wty-Bryant
Labels
automation-exempt bug This issue is a bug. good-first-issue m Effort estimation: medium p2 This is a standard priority issue v1-sync

Comments

@skmcgrail
Copy link
Member

Need to port the V1 SDK customization that set the Expect: 100-continue header for HTTP PUT operations that were larger 2 MB or streaming bodies where the content-length is unknown. Need to also provide a client configuration options that allows users to toggle this feature.

https://github.com/aws/aws-sdk-go/blob/abb93ecf8f7d631b6bc9d6701ff2938e56f1a055/service/s3/platform_handlers_go1.6.go#L18
@skmcgrail skmcgrail added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 7, 2021
@skmcgrail skmcgrail changed the title S3 Client Does not send Expect: 100-continue header for HTTP PUT requests S3 Client does not send Expect: 100-continue header for HTTP PUT requests Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Oct 8, 2022
@skmcgrail skmcgrail reopened this Oct 14, 2022
@RanVaknin RanVaknin added p1 This is a high priority issue m Effort estimation: medium labels Nov 7, 2022
@RanVaknin RanVaknin added p2 This is a standard priority issue and removed p1 This is a high priority issue labels Jan 18, 2023
@lucix-aws lucix-aws self-assigned this Jan 30, 2023
@ianbotsf ianbotsf mentioned this issue Feb 8, 2023
Closed
@wty-Bryant wty-Bryant mentioned this issue Mar 10, 2023
Merged
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wty-Bryant wty-Bryant

Labels
automation-exempt bug This issue is a bug. good-first-issue m Effort estimation: medium p2 This is a standard priority issue v1-sync
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@skmcgrail @aajtodd @RanVaknin @wty-Bryant @lucix-aws