Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/signer/v4: Remove logic determining if request needs to be resigned #876

Merged
merged 1 commit into from
Oct 6, 2016

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Oct 6, 2016

Improves the reliability of the request signature by resigning the
request each retry. In addition logic was added to the Send request
handler chain to ensure the delay between Sign and Send will not prevent
expired signature. This also brings the SDK in line with the other AWS
SDKs in their behavior of resigning the request each retry.

Related to #822

Improves the relyability of the request signature by resigning the
request each retry. In addition logic was added to the Send request
handler chain to ensure the delay between Sign and Send will not prevent
expired signature. This also brings the SDK in line with the other AWS
SDKs in their behavior of resigning the request each retry.

Related to aws#822
@jasdel jasdel merged commit 49714cf into aws:master Oct 6, 2016
@jasdel jasdel deleted the fix/requestSigning branch October 6, 2016 22:50
jasdel added a commit that referenced this pull request Oct 6, 2016
Service Model Updates
---
`service/cognitoidentityprovider`: Update Amazon Cognito Identity Provider service model
`service/devicefarm`: Update AWS Device Farm documentation
`service/opsworks`: Update AWS OpsWorks service model
`service/s3`: Update Amazon Simple Storage Service model
`service/waf`: Update AWS WAF service model

SDK Bug Fixes
---
`aws/request`: Fix HTTP Request Body race condition #874

SDK Feature Updates
---
`aws/ec2metadata`: Add support for EC2 User Data #872
`aws/signer/v4`: Remove logic determining if request needs to be resigned #876
@jasdel jasdel mentioned this pull request Oct 6, 2016
jasdel added a commit that referenced this pull request Oct 6, 2016
Service Model Updates
---
`service/cognitoidentityprovider`: Update Amazon Cognito Identity Provider service model
`service/devicefarm`: Update AWS Device Farm documentation
`service/opsworks`: Update AWS OpsWorks service model
`service/s3`: Update Amazon Simple Storage Service model
`service/waf`: Update AWS WAF service model

SDK Bug Fixes
---
`aws/request`: Fix HTTP Request Body race condition #874

SDK Feature Updates
---
`aws/ec2metadata`: Add support for EC2 User Data #872
`aws/signer/v4`: Remove logic determining if request needs to be resigned #876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant