Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransferManager - Support of CannedAccessControlList in uploadFileList method #1207

Closed
se7en007 opened this issue Jun 23, 2017 · 5 comments
Closed
Labels
feature-request A feature should be added or improved. help wanted We are asking the community to submit a PR to resolve this issue.

Comments

@se7en007
Copy link

se7en007 commented Jun 23, 2017

Hi,
I am currently working on multiple file upload method using TransferManager. I have looked into all overloaded methods for this:-

com.amazonaws.services.s3.transfer.TransferManager#uploadFileList(java.lang.String, java.lang.String, java.io.File, java.util.List<java.io.File>)  
com.amazonaws.services.s3.transfer.TransferManager#uploadFileList(java.lang.String, java.lang.String, java.io.File, java.util.List<java.io.File>, com.amazonaws.services.s3.transfer.ObjectMetadataProvider)  
com.amazonaws.services.s3.transfer.TransferManager#uploadFileList(java.lang.String, java.lang.String, java.io.File, java.util.List<java.io.File>, com.amazonaws.services.s3.transfer.ObjectMetadataProvider, com.amazonaws.services.s3.transfer.ObjectTaggingProvider)  

As per my understanding, neither ObjectMetadataProvider nor ObjectTaggingProvider can be used to set CannedAccessControlList. Is it possible to circumvent this situation?

P.S. :- In hope that I am not way off the mark, will it be good to have a overloaded method that accepts a list of PutObjectRequest? This would prevent multiple overloaded methods for every different configuration. Multiple PutObjectRequest can point to different buckets, which may hinder any S3-backend optimization if available(an assumption I made, since all existing methods needs all files to point to same bucket and same s3Prefix), but such checks can be taken care of in S3 Client JDK while hidden from user.

Thank you in advance.

@varunnvs92 varunnvs92 added the feature-request A feature should be added or improved. label Jun 23, 2017
@varunnvs92
Copy link
Contributor

varunnvs92 commented Jun 24, 2017

As per my understanding, neither ObjectMetadataProvider nor ObjectTaggingProvider can be used to set CannedAccessControlList. Is it possible to circumvent this situation?

No, you cannot set ACL using uploadFileList operations. Only tags ands metadata are supported as they are most used. You need to use the upload operation.

will it be good to have a overloaded method that accepts a list of PutObjectRequest?

We are not planning to add any new methods to TransferManager unless there is a lot of customer ask for that feature. But if you can provide a PR, we will be happy to take a look

@se7en007
Copy link
Author

se7en007 commented Jun 27, 2017

This use case reduces wait time for our users and I will be happy to add PR by next week.

@debora-ito
Copy link
Member

This is just a quick update letting you know that the SDK team has reviewed the feature request list for V1 and this one looks like a great candidate for a community PR, which we’ll help merge in and support.

@debora-ito debora-ito added help wanted We are asking the community to submit a PR to resolve this issue. and removed needs-contributors labels Feb 24, 2020
@debora-ito
Copy link
Member

We don't have plans to support this before going into Maintenance Mode, so I'll go ahead and close this feature request.

If this issue is still relevant when the v2 S3TransferManager is used (v2 S3TransferManager doesn't have a uploadFileList API though), please open a new issue in the v2 repo.

Reference:

  • Announcing end-of-support for AWS SDK for Java v1.x effective December 31, 2025 - blog post

@debora-ito debora-ito closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2024
Copy link

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. help wanted We are asking the community to submit a PR to resolve this issue.
Projects
None yet
Development

No branches or pull requests

3 participants