Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Configuration option "tls" is not honored in http handlers #1084

Closed
Amplifiyer opened this issue Apr 7, 2020 · 4 comments · Fixed by #1097
Closed

[Prod] Configuration option "tls" is not honored in http handlers #1084

Amplifiyer opened this issue Apr 7, 2020 · 4 comments · Fixed by #1097
Assignees

Comments

@Amplifiyer
Copy link
Contributor

Amplifiyer commented Apr 7, 2020

Describe the bug
Providing a custom endpoint and a tls: false configuration options to clients still result in "https" protocol to be used in the fetch-http-handler.

This is causing issues while setting localhost server as mock servers for S3 since local mock server is only running on http protocol. Related issue: aws-amplify/amplify-js#5320

SDK version number
Beta.3

Is the issue in the browser/Node.js?
Browser

To Reproduce (observed behavior)
Pass the following configuration options to any client and check the request made in the network tab has https protocol

endpoint: "http:localhost:8080",
tls: false,
forcePathStyle: true

Expected behavior
http-handler (fetch or a custom provided one) should use the right http protocol based on tls flag or from the endpoint value (aws-sdk V2).

@sammartinez
Copy link

@AllanFly120 Any update on this ticket? Just wanted to understand where it was at

@AllanZhengYP AllanZhengYP self-assigned this Apr 9, 2020
@AllanZhengYP
Copy link
Contributor

I have confirmed a root cause: smithy-lang/smithy-typescript#158. I will be working on a fix

@Amplifiyer
Copy link
Contributor Author

@AllanFly120, has this been released?

@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants