Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: codegen for issue fixed in protocol test #1086

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

AllanZhengYP
Copy link
Contributor

commits generating diffs in the clients:
awslabs/smithy-typescript@ebc70f9
awslabs/smithy-typescript@f16ee81
awslabs/smithy-typescript@b9300aa
awslabs/smithy-typescript@f2fab73
awslabs/smithy-typescript@67eac71

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 694a904
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #1086 into master will decrease coverage by 12.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1086       +/-   ##
===========================================
- Coverage   91.49%   78.79%   -12.70%     
===========================================
  Files         146      279      +133     
  Lines        2868    11598     +8730     
  Branches      511     2402     +1891     
===========================================
+ Hits         2624     9139     +6515     
- Misses        244     2459     +2215     
Impacted Files Coverage Δ
packages/smithy-client/src/client.ts 81.81% <0.00%> (-7.66%) ⬇️
packages/util-create-request/src/foo.fixture.ts 73.33% <0.00%> (-5.24%) ⬇️
...sts/aws-restjson/commands/JsonTimestampsCommand.ts 100.00% <0.00%> (ø)
...restjson/commands/TimestampFormatHeadersCommand.ts 100.00% <0.00%> (ø)
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 100.00% <0.00%> (ø)
.../commands/OmitsNullSerializesEmptyStringCommand.ts 88.23% <0.00%> (ø)
...sts/aws-restxml/commands/FlattenedXmlMapCommand.ts 100.00% <0.00%> (ø)
...ests/aws-ec2/commands/GreetingWithErrorsCommand.ts 100.00% <0.00%> (ø)
...-restxml/commands/XmlAttributesOnPayloadCommand.ts 100.00% <0.00%> (ø)
...ol_tests/aws-restjson/protocols/Aws_restJson1_1.ts 64.43% <0.00%> (ø)
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb0f0e...694a904. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit 8e077c7 into aws:master Apr 8, 2020
@lock
Copy link

lock bot commented Apr 17, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants