feat(non-clients): remove comments from transpiled JS files #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done by using shell script
for dir in */; do
( cd "$dir" && echo '{
"compilerOptions": {
"rootDir": "./src",
"declarationDir": "./dist/types"
},
"exclude": ["src/**/*.spec.ts", "dist/types/**/*"],
"extends": "../../tsconfig.types.json"
}' >tsconfig.types.json )
done
Codecov Report
@@ Coverage Diff @@
## main #2813 +/- ##
=======================================
Coverage 60.41% 60.41%
=======================================
Files 554 554
Lines 28883 28883
Branches 7076 7076
=======================================
Hits 17450 17450
Misses 11433 11433 Continue to review full report at Codecov.
|
trivikr
changed the title
AllanZhengYP
approved these changes
Sep 23, 2021
Closed
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Refs: #2799
Description
Removes comments from transpiled JS files.
Note:
tsconfig.types.jsonwhich is currently shipped in npm package. It would be reduced when we publish onlydistfolders (example experimental PR feat(client-s3): publish files in dist-* trivikr/temp-client-s3#7)Before
Total size: 9.18 MB
After
Total size: 9.44 MB
Testing
Verified that comments are not present in transpiled JS files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.