Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): remove unconditional add of util-base64 node and browser modules #4170

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 11, 2022

Issue

Refs: smithy-lang/smithy-typescript#636

Description

Removes unconditional addition of util-base64 node and browser modules

Testing

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner November 11, 2022 16:56
@trivikr trivikr merged commit 24ec718 into aws:main Nov 11, 2022
@trivikr trivikr deleted the remove-util-base64-unconditional-add branch November 11, 2022 17:13
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants