Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): shorten serialization and deserialization code in protocols files #4625

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Apr 6, 2023

Issue

smithy-lang/smithy-typescript#735

Description

Testing

  • protocol tests
  • cucumber tests

@kuhe kuhe force-pushed the feat/serde-take branch 8 times, most recently from cfe2f61 to 26d676d Compare April 12, 2023 21:20
@kuhe kuhe force-pushed the feat/serde-take branch 4 times, most recently from 3c2ddc6 to 45a5e24 Compare April 13, 2023 21:50
@kuhe
Copy link
Contributor Author

kuhe commented Apr 14, 2023

Using the included byte count script, the change is main:10_425_876 to branch:9_309_661 or ~11%.

@kuhe kuhe marked this pull request as ready for review April 14, 2023 16:17
@kuhe kuhe requested review from a team as code owners April 14, 2023 16:17
@kuhe kuhe changed the title feat(clients): apply serde brevity function feat(codegen): shorten serialization and deserialization code in protocols files Apr 14, 2023
@kuhe kuhe force-pushed the feat/serde-take branch from a91e897 to 7d15a42 Compare April 14, 2023 16:55
@github-actions
Copy link

github-actions bot commented May 2, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants