Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner STSClient doesn't longer use the provided region #5799

Closed
3 tasks done
Grmiade opened this issue Feb 15, 2024 · 3 comments
Closed
3 tasks done

Inner STSClient doesn't longer use the provided region #5799

Grmiade opened this issue Feb 15, 2024 · 3 comments
Assignees
Labels
bug This issue is a bug. closed-for-staleness p1 This is a high priority issue

Comments

@Grmiade
Copy link

Grmiade commented Feb 15, 2024

Checkboxes for prior research

Describe the bug

Since the version 3.502.0, the inner STSClient doesn't longer use the provided region in the DynamoDBClient instance when we use assume role with web identity.

SDK version number

@aws-sdk/client-dynamodb@3.502.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v20.9.0

Reproduction Steps

  • Configure envs like AWS_REGION (eu-west-3 by example), AWS_ROLE_ARN, AWS_STS_REGIONAL_ENDPOINTS and AWS_WEB_IDENTITY_TOKEN_FILE to use assume role with web identity.
  • Create a DynamoDBClient instance like new DynamoDBClient()
  • Perform any command.

Observed Behavior

The STSClient will use the us-east-1 region by default.

Expected Behavior

The STSClient should use the region specified in AWS_REGION by default (like it was before the version 3.502.0).

Possible Solution

Downgrade to 3.501.0.
Or specify explicitly the region with new DynamoDBClient({ credentials: fromNodeProviderChain({ clientConfig: { region: process.env.AWS_REGION } }) }).

Additional Information/Context

Still doesn't work with 3.514.0

@Grmiade Grmiade added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 15, 2024
@RanVaknin RanVaknin added the p1 This is a high priority issue label Feb 15, 2024
@RanVaknin RanVaknin self-assigned this Feb 15, 2024
@kuhe kuhe self-assigned this Feb 15, 2024
@kuhe
Copy link
Contributor

kuhe commented Feb 15, 2024

Thanks for reporting this. I've confirmed this bug was a result of my misunderstanding of the defaulting behavior of the global fallback us-east-1.

A fix was merged in #5800 with new tests.

The fix should be released in the next version expected later today as v3.515.0.

@kuhe kuhe added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 15, 2024
@Grmiade
Copy link
Author

Grmiade commented Feb 15, 2024

Thanks @kuhe for the reactivity 👍

@kuhe kuhe added closing-soon This issue will automatically close in 4 days unless further comments are made. and removed pending-release This issue will be fixed by an approved PR that hasn't been released yet. labels Feb 16, 2024
@github-actions github-actions bot added closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Feb 20, 2024
Copy link

github-actions bot commented Mar 5, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. closed-for-staleness p1 This is a high priority issue
Projects
None yet
Development

No branches or pull requests

3 participants