fix(signature-v4): use correct main entry point #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
trivikr
reviewed
Jan 10, 2020
This comment has been minimized.
This comment has been minimized.
AllanZhengYP
changed the title
This comment has been minimized.
This comment has been minimized.
AllanZhengYP
force-pushed
the
fix-signer-dist
branch
from
f1445c3
to
de4795c
Compare
This comment has been minimized.
This comment has been minimized.
AllanZhengYP
force-pushed
the
fix-signer-dist
branch
2 times, most recently
from
f398650
to
f42a420
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
Jan 14, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #611
The issue happens because the
distfolder was not published to NPM. And previouslydistfolder contains ES5 code in ESModule for browser runtime, whereasbuildfolder contains ES2017 code in commonjs module for NodeJS runtime.The root cause is that
mainentry point inpackage.jsonwas set tobuildfolder, sodistfolder won't be included innpm packat all during release time. This fix set commonjs and esm module code in the samedistfolder, so thatnpm packcan pick both up.This PR includes other changes:
http-serializationpackage for testingsuites.fixture.ts/cc @jordanranz
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.